Skip to content

feat(bokeh): implement line-basic#374

Merged
github-actions[bot] merged 8 commits intoplot/line-basicfrom
auto/line-basic/bokeh
Dec 7, 2025
Merged

feat(bokeh): implement line-basic#374
github-actions[bot] merged 8 commits intoplot/line-basicfrom
auto/line-basic/bokeh

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude Bot commented Dec 7, 2025

Summary

Implements line-basic for bokeh library.

Parent Issue: #205
Sub-Issue: #232
Base Branch: plot/line-basic

Implementation

  • plots/bokeh/line/line-basic/default.py

Changes

  • KISS style: simple sequential script (no functions, no classes)
  • Uses ColumnDataSource for data management
  • Output: 4800x2700 PNG with proper styling (20pt title/labels, 16pt ticks)
  • Uses Python Blue (#306998) color from style guide
  • Includes line with markers at data points

Latest Fix (afa562e)

  • Removed webdriver-manager dependency: Uses system chromedriver directly instead of webdriver-manager
  • Added better headless flags: --headless=new and --disable-gpu for improved compatibility
  • This approach is more reliable in CI environments where Chrome/Chromium and chromedriver are pre-installed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 7, 2025

✅ Plot Tests Passed

Python 3.13 (required): passed

Compatibility: 3.12 3.13

Note: Only Python 3.13 is required to pass. Python 3.12 is tested for compatibility.

Required for bokeh PNG export via export_png()
github-actions Bot and others added 6 commits December 7, 2025 05:36
Add selenium webdriver configuration required for bokeh's export_png
to work correctly in headless environments.
The uv.lock file was missing selenium and webdriver-manager for
lib-bokeh, which caused CI failures. Regenerated lock file to include
these required dependencies for bokeh PNG export.
Remove webdriver-manager dependency and use system chromedriver directly.
This is more reliable in CI environments where Chrome/Chromium and
chromedriver are pre-installed.

Changes:
- Remove webdriver-manager import
- Use Service() without explicit driver path
- Add --headless=new and --disable-gpu flags for better compatibility
Minor comment update to re-trigger CI after lockfile fix.
The lib-bokeh extra now correctly includes selenium.
@claude claude Bot added the ai-approved Quality OK, ready for merge label Dec 7, 2025
@github-actions github-actions Bot merged commit 0786958 into plot/line-basic Dec 7, 2025
8 checks passed
@github-actions github-actions Bot deleted the auto/line-basic/bokeh branch December 7, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-approved Quality OK, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant